code review 80300043: cmd/go: ensure external test files are presented to the...

cmd/go: ensure external test files are presented to the linker first

Fixes issue 7627.

CL 61970044 changed the order in which .a files are passed to gccgo's link phase. However by reversing the order it caused gccgo to complain if both internal (liba.a) and external (liba_test.a) versions of a package were presented as the former would not contain all the necessary symbols, and the latter would duplicate symbols already defined.

This change ensures that all 'fake' targets remain at the top of the final link order which should be fine as a package compiled as an external test is a superset of its internal sibling.

Looking at how gcToolchain links tests I think this change now accurately mirrors those actions which present $WORK/_test before $WORK in the link order.

[dave_cheney.net, 2014-03-26 02:41:49]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com,
michael.hudson@linaro.org),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-03-26 03:36:55]

LGTM

I guess the dependency order doesn't matter here, since all the libraries are
passed inside -Wl,-(.

Thanks.

[dave_cheney.net, 2014-03-26 04:31:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=17d7877c66d4 ***

cmd/go: ensure external test files are presented to the linker first

Fixes issue 7627.

CL 61970044 changed the order in which .a files are passed to gccgo's link
phase. However by reversing the order it caused gccgo to complain if both
internal (liba.a) and external (liba_test.a) versions of a package were
presented as the former would not contain all the necessary symbols, and the
latter would duplicate symbols already defined.

This change ensures that all 'fake' targets remain at the top of the final link
order which should be fine as a package compiled as an external test is a
superset of its internal sibling.

Looking at how gcToolchain links tests I think this change now accurately
mirrors those actions which present $WORK/_test before $WORK in the link order.

LGTM=iant
R=rsc, iant
CC=golang-codereviews, michael.hudson
https://codereview.appspot.com/80300043