Issue 8021044: code review 8021044: cmd/godoc: emit id's for constants and variables

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8021044: code review 8021044: cmd/godoc: emit id's for constants and variables (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by gri

Modified:
11 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

cmd/godoc: emit id's for constants and variables Fixes issue 5077.

Patch Set 1 #

Patch Set 2 : diff -r 79f4bd3dda85 https://code.google.com/p/go #

Patch Set 3 : diff -r 79f4bd3dda85 https://code.google.com/p/go #

Patch Set 4 : diff -r 4c7c2be5e0b6 https://code.google.com/p/go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -35 lines)			Patch
	M	src/cmd/godoc/linkify.go	View	1 2 3	6 chunks	+58 lines, -34 lines	0 comments	Download
	M	src/cmd/godoc/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 11 months ago (2013-03-27 22:02:16 UTC) #1

gri

godoc should have tests, but doesn't. doing it well is non-trivial. On Wed, Mar 27, ...

11 years, 11 months ago (2013-03-27 22:07:53 UTC) #3

gri

11 years, 11 months ago (2013-03-27 22:14:52 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=cbbdf95d3430 ***

cmd/godoc: emit id's for constants and variables

Fixes issue 5077.

R=r
CC=golang-dev
https://codereview.appspot.com/8021044

Expand All Messages | Collapse All Messages