Issue 8019043: decode: fix pointers and fix null into string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8019043: decode: fix pointers and fix null into string

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by niemeyer

Modified:
11 years, 1 month ago

Reviewers:
mp+155349, jameinel

Visibility:
Public.

Description

decode: fix pointers and fix null into string Fixes bug #1133337. https://code.launchpad.net/~niemeyer/goyaml/fix-1133337/+merge/155349 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : decode: fix pointers and fix null into string #

Patch Set 3 : decode: fix pointers and fix null into string #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -8 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	decode.go	View		2 chunks	+11 lines, -2 lines	0 comments	Download
M	decode_test.go	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	goyaml.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	resolve.go	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	sorter.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM nice bug number. The changes seem reasonable, the tests fail if you don't have ...

11 years, 1 month ago (2013-03-26 11:08:54 UTC) #2

niemeyer

11 years, 1 month ago (2013-04-02 20:30:03 UTC) #3

*** Submitted:

decode: fix pointers and fix null into string

Fixes bug #1133337.

R=jameinel
CC=
https://codereview.appspot.com/8019043

Expand All Messages | Collapse All Messages