code review 8016047: cmd/vet: fix assembly test files

cmd/vet: fix assembly test files
They should be build-tagged for vet_test not ignore,
and not have a Go package clause.

[r, 2013-03-27 23:14:28]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-03-27 23:25:08]

LGTM

I was going to complain that src/cmd/vet/vet_test.go wasn't failing when it
found no input test files.  But I see there is no such a test.  These are
manual tests?

On Wed, Mar 27, 2013 at 4:14 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/vet: fix assembly test files
> They should be build-tagged for vet_test not ignore,
> and not have a Go package clause.
>
> Please review this at
https://codereview.appspot.**com/8016047/<https://codereview.appspot.com/8016...
>
> Affected files:
>   M src/cmd/vet/test_asm1.s
>   M src/cmd/vet/test_asm2.s
>   M src/cmd/vet/test_asm3.s
>
>
> Index: src/cmd/vet/test_asm1.s
> ==============================**==============================**=======
> --- a/src/cmd/vet/test_asm1.s
> +++ b/src/cmd/vet/test_asm1.s
> @@ -3,9 +3,7 @@
>  // license that can be found in the LICENSE file.
>
>  // +build amd64
> -// +build ignore
> -
> -package main
> +// +build vet_test
>
>  TEXT ·arg1(SB),0,$0-2
>         MOVB    x+0(FP), AX
> Index: src/cmd/vet/test_asm2.s
> ==============================**==============================**=======
> --- a/src/cmd/vet/test_asm2.s
> +++ b/src/cmd/vet/test_asm2.s
> @@ -3,9 +3,7 @@
>  // license that can be found in the LICENSE file.
>
>  // +build 386
> -// +build ignore
> -
> -package main
> +// +build vet_test
>
>  TEXT ·arg1(SB),0,$0-2
>         MOVB    x+0(FP), AX
> Index: src/cmd/vet/test_asm3.s
> ==============================**==============================**=======
> --- a/src/cmd/vet/test_asm3.s
> +++ b/src/cmd/vet/test_asm3.s
> @@ -3,9 +3,7 @@
>  // license that can be found in the LICENSE file.
>
>  // +build arm
> -// +build ignore
> -
> -package main
> +// +build vet_test
>
>  TEXT ·arg1(SB),0,$0-2
>         MOVB    x+0(FP), AX
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[r, 2013-03-27 23:26:16]

There is no vet_test.go. To test vet, use
  make test
because it needs to build and run with build tags and other flags.

-rob

[r, 2013-03-27 23:29:14]

*** Submitted as https://code.google.com/p/go/source/detail?r=d0b2aef77eeb ***

cmd/vet: fix assembly test files
They should be build-tagged for vet_test not ignore,
and not have a Go package clause.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8016047