Issue 7993043: code review 7993043: libmach: respect symbol table boundaries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7993043: code review 7993043: libmach: respect symbol table boundaries (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by ality

Modified:
12 years, 1 month ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

libmach: respect symbol table boundaries Since fp->symsz includes the size of the header in the new symbol table format, we were reading past the end and decoding a few garbage symbols from data in the pc/line table.

Patch Set 1 #

Patch Set 2 : diff -r c76d8e470353 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c76d8e470353 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c76d8e470353 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 2eb36d0ca449 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/libmach/sym.c	View	1 2 3	4 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-03-24 03:47:01 UTC) #1

ality

12 years, 1 month ago (2013-03-27 12:59:22 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d040d5f08d5d ***

libmach: respect symbol table boundaries

Since fp->symsz includes the size of the header
in the new symbol table format, we were reading
past the end and decoding a few garbage symbols
from data in the pc/line table.

R=rsc, r
CC=golang-dev
https://codereview.appspot.com/7993043

Expand All Messages | Collapse All Messages