Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(531)

Issue 7981045: Deploy ghost service text mis-aligned

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by bcsaller
Modified:
11 years, 1 month ago
Reviewers:
mp+155820, jeff.pihach, gary.poster
Visibility:
Public.

Description

Deploy ghost service text mis-aligned This appears to have been an issue where the drawing of services (a ghost in this case) would be interrupted by an error prior to the translate. The text would then appear in the wrong place. https://code.launchpad.net/~bcsaller/juju-gui/ie-deploy/+merge/155820 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Deploy ghost service text mis-aligned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/views/topology/service.js View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4
bcsaller
Please take a look.
11 years, 1 month ago (2013-03-27 18:04:47 UTC) #1
jeff.pihach
LGTM Thanks for the patch!
11 years, 1 month ago (2013-03-27 18:48:51 UTC) #2
gary.poster
LGTM. Thank you!
11 years, 1 month ago (2013-03-27 20:26:01 UTC) #3
bcsaller
11 years, 1 month ago (2013-03-27 20:33:00 UTC) #4
*** Submitted:

Deploy ghost service text mis-aligned

This appears to have been an issue where the drawing 
of services (a ghost in this case) would be interrupted 
by an error prior to the translate. The text would then 
appear in the wrong place.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/7981045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b