code review 7970043: runtime/cgo, go/build: re-enable cgo for FreeBSD/ARM.

runtime/cgo, go/build: re-enable cgo for FreeBSD/ARM.

[dave_cheney.net, 2013-03-22 12:26:58]

LGTM. It will take 3 hours to run the build, and the result will be the same as
just committing and waiting for the builder so lets just go for it.

https://codereview.appspot.com/7970043/diff/2001/src/pkg/runtime/cgo/gcc_free...
File src/pkg/runtime/cgo/gcc_freebsd_arm.c (right):

https://codereview.appspot.com/7970043/diff/2001/src/pkg/runtime/cgo/gcc_free...
src/pkg/runtime/cgo/gcc_freebsd_arm.c:26: __asm__ __volatile__ (
could you please add a short comment explaining which ARMv6/7 facility is being
used here.

[minux1, 2013-03-22 13:24:51]

Hello dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2013-03-22 19:19:34]

I will follow dave's advice and submit it now.

Let's see if all.bash could pass (at least misc/cgo/test passes here).

[minux1, 2013-03-22 19:21:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=ede73f029e7a ***

runtime/cgo, go/build: re-enable cgo for FreeBSD/ARM.

R=dave, rsc
CC=golang-dev
https://codereview.appspot.com/7970043

[dave_cheney.net, 2013-03-23 01:49:08]

LGTM. It turned out that my freebsd builder binary had crashed, so I rebuilt go
to rev 07ed29a4f9f5 without incident

% go env | egrep '(GOO|GOA|CGO)'
GOARCH="arm"
GOOS="freebsd"
CGO_ENABLED="1"