Issue 7961044: code review 7961044: debug/elf: repair GNU version symbols.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7961044: code review 7961044: debug/elf: repair GNU version symbols. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by remyoudompheng

Modified:
12 years, 1 month ago

Reviewers:
rsc, dave

CC:
golang-dev, r

Visibility:
Public.

Description

debug/elf: repair GNU version symbols. After the revert of revision 9ea9e7e6e0c8 the related revision 76ff7da868c6 must be reverted too. Fixes issue 5102.

Patch Set 1 #

Patch Set 2 : diff -r 7a6736903d57 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7a6736903d57 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4dceacf2d92c https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/debug/elf/file.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 1 month ago (2013-03-22 00:21:27 UTC) #1

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=86d952ac0976 *** debug/elf: repair GNU version symbols. After the revert of revision ...

12 years, 1 month ago (2013-03-22 00:28:15 UTC) #3

dave_cheney.net

Thank you. On Fri, Mar 22, 2013 at 11:28 AM, <remyoudompheng@gmail.com> wrote: > *** Submitted ...

12 years, 1 month ago (2013-03-22 00:28:41 UTC) #4

Thanks. Do you have a test case we can add?

Expand All Messages | Collapse All Messages