Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2867)

Issue 7956045: Add the CharmInfo API call to the go env.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by frankban
Modified:
6 years, 5 months ago
Reviewers:
jeff.pihach, mp+155497, benji
Visibility:
Public.

Description

Add the CharmInfo API call to the go env. https://code.launchpad.net/~frankban/juju-gui/bug-1152340-charminfo/+merge/155497 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 14

Patch Set 2 : Add the CharmInfo API call to the go env. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 2 chunks +155 lines, -0 lines 0 comments Download
M app/store/env/python.js View 1 1 chunk +15 lines, -2 lines 0 comments Download
M test/test_env_go.js View 1 2 chunks +187 lines, -0 lines 0 comments Download
M undocumented View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
6 years, 5 months ago (2013-03-26 14:13:19 UTC) #1
jeff.pihach
LGTM Thanks! A few trivial comments and just curious if some of these tests should ...
6 years, 5 months ago (2013-03-26 14:26:36 UTC) #2
benji
LGTM https://codereview.appspot.com/7956045/diff/1/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/7956045/diff/1/app/store/env/go.js#newcode28 app/store/env/go.js:28: var newObj = {}; It is probably not ...
6 years, 5 months ago (2013-03-26 15:34:45 UTC) #3
frankban
Thanks for the reviews Jeff and Benji. https://codereview.appspot.com/7956045/diff/1/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/7956045/diff/1/app/store/env/go.js#newcode28 app/store/env/go.js:28: var newObj ...
6 years, 5 months ago (2013-03-26 17:18:51 UTC) #4
frankban
6 years, 5 months ago (2013-03-26 17:30:43 UTC) #5
*** Submitted:

Add the CharmInfo API call to the go env.

R=jeff.pihach, benji
CC=
https://codereview.appspot.com/7956045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b