Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7956043: http issue 211: Remove API deprecated in 1.14 [backwards incompatible] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by yanivi
Modified:
11 years, 1 month ago
Reviewers:
ngmiceli
CC:
peleyal
Base URL:
https://code.google.com/p/google-http-java-client/
Visibility:
Public.

Description

http issue 211: Remove API deprecated in 1.14 [backwards incompatible] https://code.google.com/p/google-http-java-client/issues/detail?id=211

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : minor #

Total comments: 2

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -2973 lines) Patch
M clirr-ignored-differences.xml View 1 1 chunk +115 lines, -0 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/AbstractHttpContent.java View 2 chunks +0 lines, -8 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java View 5 chunks +0 lines, -96 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/ByteArrayContent.java View 2 chunks +0 lines, -8 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/EmptyContent.java View 2 chunks +0 lines, -8 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/FileContent.java View 2 chunks +0 lines, -8 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpContent.java View 3 chunks +0 lines, -18 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java View 1 chunk +0 lines, -5 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/HttpMethod.java View 1 chunk +0 lines, -32 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/HttpParser.java View 1 chunk +0 lines, -50 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java View 1 2 3 14 chunks +2 lines, -221 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpRequestFactory.java View 2 chunks +0 lines, -19 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java View 3 chunks +1 line, -26 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java View 2 chunks +0 lines, -33 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/InputStreamContent.java View 2 chunks +0 lines, -8 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/LowLevelHttpRequest.java View 2 chunks +0 lines, -16 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/MultipartRelatedContent.java View 1 chunk +0 lines, -217 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java View 1 chunk +0 lines, -849 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpParser.java View 1 chunk +0 lines, -194 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpRequest.java View 1 chunk +0 lines, -258 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpRequestInitializer.java View 1 chunk +0 lines, -57 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/xml/XmlHttpParser.java View 1 chunk +0 lines, -181 lines 0 comments Download
R google-http-client/src/main/java/com/google/api/client/http/xml/atom/AtomParser.java View 1 chunk +0 lines, -59 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/Json.java View 2 chunks +0 lines, -8 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java View 1 chunk +0 lines, -6 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/JsonParser.java View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockHttpContent.java View 4 chunks +0 lines, -22 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockHttpTransport.java View 1 2 chunks +0 lines, -21 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpRequest.java View 5 chunks +0 lines, -29 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpResponse.java View 3 chunks +0 lines, -10 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/util/Data.java View 2 chunks +0 lines, -14 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/AbstractHttpContentTest.java View 1 chunk +0 lines, -6 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/EmptyContentTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/HttpHeadersTest.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java View 2 chunks +0 lines, -50 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/HttpResponseExceptionTest.java View 1 2 chunks +0 lines, -11 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/http/MultipartRelatedContentTest.java View 1 chunk +0 lines, -78 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/http/json/JsonHttpClientTest.java View 1 chunk +0 lines, -259 lines 0 comments Download
R google-http-client/src/test/java/com/google/api/client/http/json/JsonHttpRequestTest.java View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 5
yanivi
11 years, 1 month ago (2013-03-21 20:42:54 UTC) #1
yanivi
11 years, 1 month ago (2013-03-27 15:50:50 UTC) #2
ngmiceli
LGTM https://codereview.appspot.com/7956043/diff/16001/google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java File google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java (left): https://codereview.appspot.com/7956043/diff/16001/google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java#oldcode150 google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java:150: static void downloadMedia(HttpResponse response, File file) Why is ...
11 years, 1 month ago (2013-03-27 16:08:13 UTC) #3
yanivi
https://codereview.appspot.com/7956043/diff/16001/google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java File google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java (left): https://codereview.appspot.com/7956043/diff/16001/google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java#oldcode150 google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java:150: static void downloadMedia(HttpResponse response, File file) On 2013/03/27 16:08:13, ...
11 years, 1 month ago (2013-03-27 16:11:07 UTC) #4
ngmiceli
11 years, 1 month ago (2013-03-27 16:13:04 UTC) #5 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b