code review 79550043: time: add comment explaining rejection of years outside...

time: add comment explaining rejection of years outside [0000,9999]

This has come up twice now. Redirect future questions
to the explanation in the issue tracker.

[rsc, 2014-03-24 19:20:07]

Hello r (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2014-03-24 20:07:12]

LGTM

On Mon, Mar 24, 2014 at 12:20 PM,  <rsc@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> time: add comment explaining rejection of years outside [0000,9999]
>
> This has come up twice now. Redirect future questions
> to the explanation in the issue tracker.
>
> Please review this at https://codereview.appspot.com/79550043/
>
> Affected files (+2, -0 lines):
>   M src/pkg/time/time.go
>
>
> Index: src/pkg/time/time.go
> ===================================================================
> --- a/src/pkg/time/time.go
> +++ b/src/pkg/time/time.go
> @@ -934,6 +934,8 @@
>  // The time is a quoted string in RFC 3339 format, with sub-second
> precision added if present.
>  func (t Time) MarshalJSON() ([]byte, error) {
>         if y := t.Year(); y < 0 || y >= 10000 {
> +               // RFC 3339 is clear that years are 4 digits exactly.
> +               // See golang.org/issue/4556#c15 for more discussion.
>                 return nil, errors.New("Time.MarshalJSON: year outside of
> range [0,9999]")
>         }
>         return []byte(t.Format(`"` + RFC3339Nano + `"`)), nil
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[r, 2014-03-24 20:39:31]

LGTM

[rsc, 2014-03-25 00:34:23]

*** Submitted as https://code.google.com/p/go/source/detail?r=f60620ad71fa ***

time: add comment explaining rejection of years outside [0000,9999]

This has come up twice now. Redirect future questions
to the explanation in the issue tracker.

LGTM=iant, r
R=r, iant
CC=golang-codereviews
https://codereview.appspot.com/79550043

[gobot, 2014-03-25 01:27:04]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/0e12e8b244b1bc8a551d583da7f35f594364be15