Descriptionuniter: fix flaky tests, poor isolation
The changed test case wasn't waiting for the right thing, because there
wasn't anything clear to wait for; changed the uniter deploy code such
that it only notifies remote state about a new charm *after* it's downloaded
and verified it but still before the change is applied. I can then write the
test such that I immediately request the uniter stop just after it starts
installing the new charm -- a procedure it won't interrupt -- and thus delay
the verifyCharm check until the charm is sure to have been deployed.
This change has been verified by rogpeppe and frankban, both of whom saw the
original failures and now no longer do.
I also fixed up test isolation via Reset, which was kinda crackful before.
https://code.launchpad.net/~fwereade/juju-core/fix-1157898/+merge/154765
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 7
Patch Set 2 : uniter: fix flaky tests, poor isolation #
MessagesTotal messages: 4
|