Issue 79470043: state/api: further api client consolidation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 79470043: state/api: further api client consolidation

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by rog

Modified:
10 years, 1 month ago

Reviewers:
dimitern, mp+212425

Visibility:
Public.

Description

state/api: further api client consolidation This carries on the work started by https://codereview.appspot.com/78890043 https://code.launchpad.net/~rogpeppe/juju-core/527-consolidate-api-client/+merge/212425 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api: further api client consolidation #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -159 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/client.go	View	31 chunks	+46 lines, -42 lines	0 comments	Download
M	state/api/deployer/deployer.go	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	state/api/deployer/machine.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/deployer/unit.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/api/firewaller/firewaller.go	View	2 chunks	+13 lines, -33 lines	0 comments	Download
M	state/api/firewaller/machine.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/api/firewaller/service.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/api/firewaller/state_test.go	View	2 chunks	+3 lines, -38 lines	0 comments	Download
M	state/api/firewaller/unit.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	state/api/keymanager/client.go	View	5 chunks	+8 lines, -4 lines	0 comments	Download
M	state/api/keyupdater/authorisedkeys.go	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	state/api/logger/logger.go	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	state/api/machiner/machine.go	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	state/api/machiner/machiner.go	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	state/api/provisioner/machine.go	View	12 chunks	+12 lines, -12 lines	0 comments	Download
M	state/api/upgrader/upgrader.go	View	5 chunks	+8 lines, -4 lines	0 comments	Download
M	state/api/usermanager/client.go	View	3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Thanks! LGTM.

Expand All Messages | Collapse All Messages