Issue 7946043: Converted _nsRouter to nsRouter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7946043: Converted _nsRouter to nsRouter

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by jeff.pihach

Modified:
12 years ago

Reviewers:
benji, mp+154737, matthew.scott

Visibility:
Public.

Description

Converted _nsRouter to nsRouter https://code.launchpad.net/~hatch/juju-gui/1158351-nsrouting/+merge/154737 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Converted _nsRouter to nsRouter #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -31 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	app/assets/javascripts/ns-routing-app-extension.js	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	app/views/environment.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	app/views/service.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	app/views/topology/service.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/unit.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/test_service_module.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_service_view.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/test_unit_view.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

On 2013/03/21 15:53:22, matthew.scott wrote: > LGTM Thanks all for the reviews!

12 years ago (2013-03-21 15:54:15 UTC) #4

jeff.pihach

12 years ago (2013-03-21 15:58:07 UTC) #5

*** Submitted:

Converted _nsRouter to nsRouter

R=benji, matthew.scott
CC=
https://codereview.appspot.com/7946043

Expand All Messages | Collapse All Messages