Issue 7945044: statecmd: don't use juju.Conn unnecessarily

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7945044: statecmd: don't use juju.Conn unnecessarily

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
dimitern, fwereade, mp+154744

Visibility:
Public.

Description

statecmd: don't use juju.Conn unnecessarily There's an associated cost when the API uses juju.Conn, so we want to avoid it when reasonable. This change moves some operations from juju into state because they don't require juju.Conn's associated Environ. https://code.launchpad.net/~rogpeppe/juju-core/251-statecmd-remove-unnecessary-conn/+merge/154744 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : statecmd: don't use juju.Conn unnecessarily #

Total comments: 1

Patch Set 3 : statecmd: don't use juju.Conn unnecessarily #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -190 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/destroymachine.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	juju/conn.go	View	1 2	3 chunks	+2 lines, -57 lines	0 comments	Download
M	juju/conn_test.go	View	1 2	1 chunk	+0 lines, -119 lines	0 comments	Download
M	state/machine_test.go	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	state/state.go	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	state/statecmd/destroyunit.go	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	state/statecmd/setconstraints.go	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	state/unit_test.go	View	1 2	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

LGTM https://codereview.appspot.com/7945044/diff/2001/state/state.go File state/state.go (right): https://codereview.appspot.com/7945044/diff/2001/state/state.go#newcode757 state/state.go:757: // TODO(rog) make this a transaction? Probably a ...

11 years, 1 month ago (2013-03-22 00:37:23 UTC) #2

rog

11 years, 1 month ago (2013-03-22 17:10:50 UTC) #4

*** Submitted:

statecmd: don't use juju.Conn unnecessarily

There's an associated cost when the API uses juju.Conn,
so we want to avoid it when reasonable.
This change moves some operations from juju into
state because they don't require juju.Conn's associated
Environ.

R=fwereade, dimitern
CC=
https://codereview.appspot.com/7945044

Expand All Messages | Collapse All Messages