Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 7945043: Make 'traceur' ignore shebang lines in files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by usrbincc
Modified:
13 years, 2 months ago
Reviewers:
slightlylate, arv
CC:
traceur-compiler-reviews_googlegroups.com
Base URL:
https://code.google.com/p/traceur-compiler/@master
Visibility:
Public.

Description

Make 'traceur' ignore shebang lines in files. BUG=https://code.google.com/p/traceur-compiler/issues/detail?id=221 TEST=None

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/node/inline-module.js View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 2
usrbincc
Even though the blanket shebang ignore is a blunt instrument, it does replicate node's behavior, ...
13 years, 2 months ago (2013-03-21 15:46:43 UTC) #1
arv
13 years, 2 months ago (2013-03-21 16:16:13 UTC) #2
LGTM

FYI, if you "npm install -g" you can do

#!/usr/bin/env traceur

https://codereview.appspot.com/7945043/diff/1/src/node/inline-module.js
File src/node/inline-module.js (right):

https://codereview.appspot.com/7945043/diff/1/src/node/inline-module.js#newco...
src/node/inline-module.js:137: data = '//' + data;
On 2013/03/21 15:46:43, usrbincc wrote:
> It's not as elegant as removing, but it's by far the simplest solution
> that maintains line numbering while also handling odd cases like files
> that contain only a shebang line that does not end in a newline.

Agreed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b