local: all logs in one directory

local: all logs in one directory

With one exception (cloud-init-output.log), this
change puts all log files in one directory on the
host system: /var/log/juju-{{.Namespace}}. We now
symlink ~/.juju/local/log to that directory,
rather than creating symlinks to individual files.

The cloud-init-output.log file is located outside
of the log dir to simplify ownership and dir existence
logic. It is now located in root-dir/.

I've also added some extra error checking, and moved
the chown syslog:adm to environs/cloudinit.

Live tested with local and azure (for cloudinit changes).

Can't say it fixes lp:1295501 as I can't reproduce
the problem, but it at least simplifies the logic.

https://code.launchpad.net/~axwalk/juju-core/lp1295501-local-logs-one-dir/+merge/212346

(do not edit description out of merge proposal)

[axw, 2014-03-24 04:14:15]

Please take a look.

[wallyworld, 2014-03-24 06:17:04]

LGTM with a suggestion. Could we also add a test for the environ.go changes?

https://codereview.appspot.com/79310043/diff/1/provider/local/config.go
File provider/local/config.go (right):

https://codereview.appspot.com/79310043/diff/1/provider/local/config.go#newco...
provider/local/config.go:87: return fmt.Sprintf("/var/log/juju-%s",
c.namespace())
fmt.Sprintf("%s-%s", agent.DefaultLogDir, c.namespace())

[axw, 2014-03-24 06:34:55]

Please take a look.

https://codereview.appspot.com/79310043/diff/1/provider/local/config.go
File provider/local/config.go (right):

https://codereview.appspot.com/79310043/diff/1/provider/local/config.go#newco...
provider/local/config.go:87: return fmt.Sprintf("/var/log/juju-%s",
c.namespace())
On 2014/03/24 06:17:05, wallyworld wrote:
> fmt.Sprintf("%s-%s", agent.DefaultLogDir, c.namespace())

Done.