Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(642)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7927044: code review 7927044: bufio: add some tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by bradfitz
Modified:
12 years, 1 month ago
Reviewers:
dave
CC:
golang-dev, adg
Visibility:
Public.

Description

bufio: add some tests

Patch Set 1 #

Patch Set 2 : diff -r 86d952ac0976 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 86d952ac0976 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 86d952ac0976 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M src/pkg/bufio/bufio_test.go View 1 2 3 3 chunks +44 lines, -3 lines 0 comments Download

Messages

Total messages: 10
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2013-03-22 01:54:12 UTC) #1
adg
LGTM https://codereview.appspot.com/7927044/diff/3/src/pkg/bufio/bufio_test.go File src/pkg/bufio/bufio_test.go (right): https://codereview.appspot.com/7927044/diff/3/src/pkg/bufio/bufio_test.go#newcode990 src/pkg/bufio/bufio_test.go:990: t.Fatalf("1nd nil Read = %v; want nil", err) ...
12 years, 1 month ago (2013-03-22 02:46:26 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=b22e986f983e *** bufio: add some tests R=golang-dev, adg CC=golang-dev https://codereview.appspot.com/7927044
12 years, 1 month ago (2013-03-22 02:59:55 UTC) #3
dave_cheney.net
LGTM. bufio/bufio.go Reader.ReadBytes 100.00% (24/24) bufio/bufio.go Reader.Read 100.00% (22/22) bufio/bufio.go Reader.ReadSlice 100.00% (18/18) bufio/bufio.go Writer.ReadFrom ...
12 years, 1 month ago (2013-03-22 03:55:16 UTC) #4
bradfitz
What is that? Coverage? How'd you make that? On Thu, Mar 21, 2013 at 8:55 ...
12 years, 1 month ago (2013-03-22 03:57:00 UTC) #5
dave_cheney.net
go get github.com/axw/gocov/gocov gocov test bufio | gocov report There is some breakage at the ...
12 years, 1 month ago (2013-03-22 03:58:11 UTC) #6
bradfitz
On Thu, Mar 21, 2013 at 8:58 PM, Dave Cheney <dave@cheney.net> wrote: > go get ...
12 years, 1 month ago (2013-03-22 03:59:19 UTC) #7
dave_cheney.net
lucky(~/go/src) % cat old.txt bufio/bufio.go Reader.ReadBytes 100.00% (24/24) bufio/bufio.go Reader.ReadSlice 100.00% (18/18) bufio/bufio.go Writer.ReadFrom 100.00% ...
12 years, 1 month ago (2013-03-22 04:01:11 UTC) #8
bradfitz
Impressive tool. Now we just need a covcmp tool. :-) On Thu, Mar 21, 2013 ...
12 years, 1 month ago (2013-03-22 04:06:49 UTC) #9
dave_cheney.net
12 years, 1 month ago (2013-03-22 04:10:46 UTC) #10 
All props to axw, this is his joint. There is also,
https://github.com/matm/gocov-html

On Fri, Mar 22, 2013 at 3:06 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Impressive tool.  Now we just need a covcmp tool.  :-)
>
>
> On Thu, Mar 21, 2013 at 9:01 PM, Dave Cheney <dave@cheney.net> wrote:
>>
>> lucky(~/go/src) % cat old.txt
>>
>> bufio/bufio.go   Reader.ReadBytes        100.00% (24/24)
>> bufio/bufio.go   Reader.ReadSlice        100.00% (18/18)
>> bufio/bufio.go   Writer.ReadFrom         100.00% (18/18)
>> bufio/bufio.go   Reader.ReadRune         100.00% (12/12)
>> bufio/bufio.go   Reader.fill             100.00% (10/10)
>> bufio/scan.go    isSpace                 100.00% (10/10)
>> bufio/bufio.go   Reader.ReadByte         100.00% (9/9)
>> bufio/bufio.go   Reader.UnreadRune       100.00% (6/6)
>> bufio/bufio.go   Reader.writeBuf         100.00% (3/3)
>> bufio/scan.go    Scanner.Err             100.00% (3/3)
>> bufio/scan.go    dropCR                  100.00% (3/3)
>> bufio/bufio.go   Reader.readErr          100.00% (3/3)
>> bufio/scan.go    Scanner.setErr          100.00% (2/2)
>> bufio/bufio.go   Reader.ReadString       100.00% (2/2)
>> bufio/bufio.go   Writer.Buffered         100.00% (1/1)
>> bufio/bufio.go   NewReader               100.00% (1/1)
>> bufio/bufio.go   Reader.Buffered         100.00% (1/1)
>> bufio/scan.go    Scanner.Text            100.00% (1/1)
>> bufio/scan.go    Scanner.Split           100.00% (1/1)
>> bufio/scan.go    Scanner.Bytes           100.00% (1/1)
>> bufio/bufio.go   NewWriter               100.00% (1/1)
>> bufio/bufio.go   Writer.Available        100.00% (1/1)
>> bufio/scan.go    NewScanner              100.00% (1/1)
>> bufio/bufio.go   Reader.Read             95.45% (21/22)
>> bufio/bufio.go   Reader.ReadLine         94.74% (18/19)
>> bufio/scan.go    ScanWords               93.75% (15/16)
>> bufio/bufio.go   Writer.Flush            93.33% (14/15)
>> bufio/bufio.go   Writer.WriteString      92.31% (12/13)
>> bufio/bufio.go   NewWriterSize           88.89% (8/9)
>> bufio/bufio.go   Reader.Peek             86.67% (13/15)
>> bufio/scan.go    ScanLines               85.71% (6/7)
>> bufio/bufio.go   NewReaderSize           83.33% (5/6)
>> bufio/scan.go    ScanRunes               80.00% (8/10)
>> bufio/scan.go    Scanner.Scan            73.68% (28/38)
>> bufio/bufio.go   Reader.WriteTo          73.33% (11/15)
>> bufio/bufio.go   Writer.Write            73.33% (11/15)
>> bufio/bufio.go   Writer.WriteByte        71.43% (5/7)
>> bufio/scan.go    ScanBytes               66.67% (2/3)
>> bufio/bufio.go   Writer.WriteRune        58.82% (10/17)
>> bufio/bufio.go   Reader.UnreadByte       50.00% (6/12)
>> bufio/scan.go    Scanner.advance         50.00% (4/8)
>> bufio/bufio.go   NewReadWriter           0.00% (0/1)
>> bufio            ------------------      86.58% (329/380)
>>
>> On Fri, Mar 22, 2013 at 2:59 PM, Brad Fitzpatrick <bradfitz@golang.org>
>> wrote:
>> > On Thu, Mar 21, 2013 at 8:58 PM, Dave Cheney <dave@cheney.net> wrote:
>> >>
>> >> go get github.com/axw/gocov/gocov
>> >> gocov test bufio | gocov report
>> >
>> >
>> > fancy!
>> >
>> > I'm lazy: what was the delta from before this CL?
>> >
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b