Issue 7925045: state/watcher, state/presence: don't log so much

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7925045: state/watcher, state/presence: don't log so much

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
dimitern, dave, mp+155814

Visibility:
Public.

Description

state/watcher, state/presence: don't log so much We remove two log messages which, when I ran juju for a day, accounted for >95% of the size of the logs between them. https://code.launchpad.net/~rogpeppe/juju-core/260-smaller-logs/+merge/155814 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/watcher, state/presence: don't log so much #

Patch Set 3 : state/watcher, state/presence: don't log so much #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/presence/presence.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	state/watcher/watcher.go	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

Awesome! Thank you very much for this much needed change that culls the log pollution! ...

11 years, 1 month ago (2013-03-27 17:58:52 UTC) #2

dave_cheney.net

LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM

11 years, 1 month ago (2013-03-27 20:12:29 UTC) #3

rog

11 years, 1 month ago (2013-03-28 13:21:56 UTC) #5

*** Submitted:

state/watcher, state/presence: don't log so much

We remove two log messages which, when I ran
juju for a day, accounted for >95% of the size
of the logs between them.

R=dimitern, dfc
CC=
https://codereview.appspot.com/7925045

Expand All Messages | Collapse All Messages