code review 79230043: unicode/utf8: minor code simplification

unicode/utf8: minor code simplification

It's a little bit waste to check if r is not a surrogate
code point because RuneError is not a surrogate code point.

[ruiu, 2014-03-23 21:21:31]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-03-23 22:10:33]

I think the existing code is a little easier to understand.  None of these
conditions will ever be true for normal code, so your simplification doesn't
make it any more efficient for the normal case.

[ruiu, 2014-03-23 22:24:21]

Thank you for reviewing.

I don't have a strong preference on this, so I'm totally
OK with the original code, but I have a different idea to
convert these if's to a switch. It might be easier to read
than before. How does this look like to you?

[iant, 2014-03-23 22:40:57]

LGTM

[iant, 2014-03-23 22:44:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=01358eb1cea5 ***

unicode/utf8: minor code simplification

It's a little bit waste to check if r is not a surrogate
code point because RuneError is not a surrogate code point.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/79230043

Committer: Ian Lance Taylor <iant@golang.org>