Issue 7919043: rpc: fix race in test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7919043: rpc: fix race in test

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
dave, jameinel, mp+154299

Visibility:
Public.

Description

rpc: fix race in test We were sometimes closing the listener before it got a chance to listen... https://code.launchpad.net/~rogpeppe/juju-core/248-fix-rpc-test-race/+merge/154299 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : rpc: fix race in test #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	rpc/rpc_test.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM, and a request, don't forget to use lbox -bug=1157553 https://codereview.appspot.com/7919043/diff/1/rpc/rpc_test.go File rpc/rpc_test.go (right): https://codereview.appspot.com/7919043/diff/1/rpc/rpc_test.go#newcode479 ...

11 years, 1 month ago (2013-03-20 09:01:34 UTC) #2

jameinel

I can confirm that with GOMAXPROCS=2 the test failed before, but passes now. LGTM

11 years, 1 month ago (2013-03-20 09:19:26 UTC) #3

rog

11 years, 1 month ago (2013-03-20 10:22:45 UTC) #4

*** Submitted:

rpc: fix race in test

We were sometimes closing the listener before
it got a chance to listen...

R=dfc, jameinel
CC=
https://codereview.appspot.com/7919043

https://codereview.appspot.com/7919043/diff/1/rpc/rpc_test.go
File rpc/rpc_test.go (right):

https://codereview.appspot.com/7919043/diff/1/rpc/rpc_test.go#newcode479
rpc/rpc_test.go:479: srvDone := make(chan error, 1)
On 2013/03/20 09:01:34, dfc wrote:
> please make this done = make(chan error, 1), or remove the named return value
> above. It is very confusing to have the return param named 'done', but the
value
> returned called 'srvDone' 

Done.

Expand All Messages | Collapse All Messages