Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15514)

Issue 7917: Repairing NPC camera when in low areas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by Lanarel
Modified:
14 years, 9 months ago
Reviewers:
andy.dai
CC:
planeshift-reviews_googlegroups.com
Base URL:
https://planeshift.svn.sourceforge.net/svnroot/planeshift/trunk/
Visibility:
Public.

Description

Peeg re-enabled npc camera, but we found things go wrong if the npc position has negative height, such as in hydlaa plaza. I made a small correction to the strange formula, which does not add a negative value, but just takes the top of the characters. Again, no bug report for this :). Just preparing you all for the spam you will get when everyone dives into the code :P

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
src/client/pscamera.cpp View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Lanarel
15 years, 5 months ago (2008-11-03 21:40:36 UTC) #1
Khaki
Has this been tested and verified? On 2008/11/03 21:40:36, Lanarel wrote: >
15 years, 5 months ago (2008-11-04 02:45:28 UTC) #2
Lanarel
On 2008/11/04 02:45:28, Khaki wrote: > Has this been tested and verified? > > On ...
15 years, 5 months ago (2008-11-04 07:17:57 UTC) #3
Khaki
Looks good to me. On 2008/11/04 07:17:57, Lanarel wrote: > On 2008/11/04 02:45:28, Khaki wrote: ...
15 years, 5 months ago (2008-11-04 16:12:50 UTC) #4
Lanarel
15 years, 5 months ago (2008-11-07 14:01:08 UTC) #5
committed by welall (without the comments I forgot to remove :) ).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b