Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(809)

Issue 7916: Small safety patch related to quests

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by Lanarel
Modified:
9 years, 4 months ago
Reviewers:
Khaki
CC:
planeshift-reviews_googlegroups.com
Base URL:
https://planeshift.svn.sourceforge.net/svnroot/planeshift/trunk/
Visibility:
Public.

Description

When I fixed some quest problems long ago, I added some lines that would prevent a combination of trigger without prior response when this was already done. To pass this information outside the function, I set the last general response to none. This can theoretically cause side effects. As it only prevents one more check (my other changes already removed many more), it is safer to delete these lines. No bug url, as old bug was in old bug tracker, and a new bug is hopefully prevented this way.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
src/server/bulkobjects/psnpcdialog.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Lanarel
15 years, 5 months ago (2008-11-03 20:18:15 UTC) #1
Khaki
Why remove only these lines and not the other lines containing TestedWithoutLastResponse? On 2008/11/03 20:18:15, ...
15 years, 5 months ago (2008-11-04 02:43:30 UTC) #2
Lanarel
15 years, 5 months ago (2008-11-04 07:16:36 UTC) #3
That TestedWithoutLastResponse makes sure the combination of tested trigger with
no last response is only tested once within this function, instead as it was
before for each quest that had no last response. Certainly just after this
change, that would mean every quest :). Currently, that might be much rarer,
probably all quests at the beginning of a quest step. The lines I removed made
sure one more test outside this function was not done, by passing the value of
TestedWithoutLastResponse to outside this function in a way that is not really
100% good.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b