code review 7906045: runtime: correct misplaced right brace in Linux SIGBUS ...

runtime: correct misplaced right brace in Linux SIGBUS handling

I'm not sure how to write a test for this.  The change in
behaviour is that if you somehow get a SIGBUS signal for an
address >= 0x1000, the program will now crash rather than
calling panic.  As far as I know, on x86 GNU/Linux, the only
way to get a SIGBUS (rather than a SIGSEGV) is to set the
stack pointer to an invalid value.

[iant, 2013-03-22 22:37:27]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-03-22 22:45:49]

LGTM

[iant, 2013-03-23 00:32:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=5290388a2e3f ***

runtime: correct misplaced right brace in Linux SIGBUS handling

I'm not sure how to write a test for this.  The change in
behaviour is that if you somehow get a SIGBUS signal for an
address >= 0x1000, the program will now crash rather than
calling panic.  As far as I know, on x86 GNU/Linux, the only
way to get a SIGBUS (rather than a SIGSEGV) is to set the
stack pointer to an invalid value.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7906045

[albert.strasheim, 2013-03-24 06:26:41]

On 2013/03/23 00:32:11, iant wrote:
> calling panic.  As far as I know, on x86 GNU/Linux, the only
> way to get a SIGBUS (rather than a SIGSEGV) is to set the
> stack pointer to an invalid value.

FWIW, I think you also get SIGBUS if you mmap a file, remove its associated
block device and try to read from the mapping. Easy to test with a removable USB
device.

Cheers

Albert