Planeshift prospect patch bug 832

This is the patch for http://www.hydlaa.com/flyspray_upgrade/index.php?do=details&task_id=832&project=2&order=status&sort=desc
It is very well possible that prospect Geckolous is no longer active. I tested the patch and it fixes the bug.
Base revision I forgot (should be around 30th of october, in code that does not change much).
If there is more info you want in these messages, or if I did somethings wrong (first try), let me know :)

[Lanarel, 2008-11-01 17:33:54]

On 2008/10/31 20:43:29, Lanarel wrote:
> 

Check if Khaki can see this, and also to ask him to look at the format of my
patch. I think I should use a different one.

[Lanarel, 2008-11-01 17:55:53]

This time with root dir as base. Hopefully this works better

[Khaki, 2008-11-01 20:06:06]

Looks good to me.

I'm surprised that callers of PlaceItem don't check that the slot is empty
first.

[Kayden, 2008-11-02 15:08:38]

On 2008/11/01 20:06:06, Khaki wrote:
> Looks good to me.
> 
> I'm surprised that callers of PlaceItem don't check that the slot is empty
> first.

That may be because of stacking—sometimes you -can- place another item in the
same slot as another.  I'm not sure about this code though, it's been a long
time since I've looked at it.  I once tried to do something similar—an
in-transit ghost status for all un-acknowledged slot operations—but ran into a
lot of issues with stacks and partial moves.

This patch looks good though.