Issue 7895045: oauth2client: update compute engine token endpoint

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7895045: oauth2client: update compute engine token endpoint

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by proppy

Modified:
11 years, 1 month ago

Reviewers:
jcgregorio_google, dhermes

CC:
google-api-python-client_googlegroups.com, krisbin_google.com

Visibility:
Public.

More Reviews

Description

update compute engine token endpoint

Patch Set 1 #

Patch Set 2 : update implementation #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -25 lines)			Patch
	M	oauth2client/gce.py	View	1	4 chunks	+7 lines, -17 lines	1 comment	Download
	M	tests/test_oauth2client_gce.py	View		2 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

proppy

Update the gce oauth2client integration to call the documented endpoints for access token, and remove ...

11 years, 1 month ago (2013-03-20 20:36:02 UTC) #1

dhermes

11 years, 1 month ago (2013-03-20 21:53:18 UTC) #2

Great change to see!

https://codereview.appspot.com/7895045/diff/2001/oauth2client/gce.py
File oauth2client/gce.py (right):

https://codereview.appspot.com/7895045/diff/2001/oauth2client/gce.py#newcode51
oauth2client/gce.py:51: def __init__(self, **kwargs):
I asked previously to remove scope from this but it seems we can't change
signatures in a breaking fashion until a v2.0.

A middle ground would be to have a *args which also does nothing.

On a side note, these variable names should be unused_args and unused_kwargs to
indicate their lack of use.

Expand All Messages | Collapse All Messages