Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1235)

Issue 7889043: Added toString to SkMaskFilter-derived classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by robertphillips
Modified:
11 years, 3 months ago
Reviewers:
DerekS, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added toString to SkMaskFilter-derived classes

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1 line) Patch
M include/core/SkMaskFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/effects/SkEmbossMaskFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkKernel33MaskFilter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M include/effects/SkStippleMaskFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkTableMaskFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleText.cpp View 2 chunks +22 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +31 lines, -0 lines 0 comments Download
M src/effects/SkEmbossMaskFilter.cpp View 2 chunks +22 lines, -0 lines 0 comments Download
M src/effects/SkKernel33MaskFilter.cpp View 3 chunks +23 lines, -0 lines 0 comments Download
M src/effects/SkStippleMaskFilter.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M src/effects/SkTableMaskFilter.cpp View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6
robertphillips
11 years, 3 months ago (2013-03-18 14:45:08 UTC) #1
DerekS
the idea looks OK to me, but want to get mike's opinion as it is ...
11 years, 3 months ago (2013-03-18 17:11:07 UTC) #2
reed1
Is there a useful unittest for this? (not sure) Can you add a dump of ...
11 years, 3 months ago (2013-03-18 17:25:39 UTC) #3
robertphillips
These methods are used by the debugger to display the paint details for a command. ...
11 years, 3 months ago (2013-03-18 17:50:20 UTC) #4
reed1
lgtm
11 years, 3 months ago (2013-03-18 17:51:17 UTC) #5
robertphillips
11 years, 3 months ago (2013-03-18 17:54:02 UTC) #6
Message was sent while issue was closed.
committed as r8194
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b