Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1404)

Issue 7888047: code review 7888047: cmd/cgo: fix the cgo example on multiple assignment context.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by tebeka
Modified:
6 years, 8 months ago
Reviewers:
bradfitz
CC:
golang-dev, minux1, rsc, bradfitz
Visibility:
Public.

Description

cmd/cgo: fix the cgo example on multiple assignment context. Change from atoi to strtol since atoi does not set errno.

Patch Set 1 #

Patch Set 2 : diff -r b0ff2babd1f5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b0ff2babd1f5 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 86d952ac0976 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 86d952ac0976 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/cgo/doc.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
tebeka
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, minux.ma@gmail.com), I'd like you to review this change to https://code.google.com/p/go/
6 years, 8 months ago (2013-03-21 16:05:51 UTC) #1
minux1
https://codereview.appspot.com/7888047/diff/5001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/7888047/diff/5001/src/cmd/cgo/doc.go#newcode73 src/cmd/cgo/doc.go:73: n, err := C.strtol(C.CString("10"), nil, 50) // base too ...
6 years, 8 months ago (2013-03-21 16:39:18 UTC) #2
tebeka
On 2013/03/21 16:39:18, minux wrote: > i now think we'd better use a simpler example ...
6 years, 8 months ago (2013-03-21 16:44:51 UTC) #3
minux1
On Fri, Mar 22, 2013 at 12:44 AM, <miki.tebeka@gmail.com> wrote: > On 2013/03/21 16:39:18, minux ...
6 years, 8 months ago (2013-03-21 17:05:54 UTC) #4
rsc
C.close(-1)
6 years, 8 months ago (2013-03-21 20:13:38 UTC) #5
minux1
On Fri, Mar 22, 2013 at 4:13 AM, Russ Cox <rsc@golang.org> wrote: > C.close(-1) too ...
6 years, 8 months ago (2013-03-21 20:22:42 UTC) #6
rsc
Okay, C.sqrt(-1) it is.
6 years, 8 months ago (2013-03-21 20:41:59 UTC) #7
tebeka
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
6 years, 8 months ago (2013-03-22 01:55:39 UTC) #8
bradfitz
LGTM On Thu, Mar 21, 2013 at 6:55 PM, <miki.tebeka@gmail.com> wrote: > Hello golang-dev@googlegroups.com, minux.ma@gmail.com, ...
6 years, 8 months ago (2013-03-22 03:05:58 UTC) #9
bradfitz
6 years, 8 months ago (2013-03-22 03:06:28 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=cf22c93f26fa ***

cmd/cgo: fix the cgo example on multiple assignment context.

Change from atoi to strtol since atoi does not set errno.

R=golang-dev, minux.ma, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/7888047

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b