Issue 7885045: Fix bug 1157138

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7885045: Fix bug 1157138

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by gary.poster

Modified:
11 years, 1 month ago

Reviewers:
mp+154099, benji, matthew.scott

Visibility:
Public.

Description

Fix bug 1157138 Make service displayName dynamic so that newly created services accurately change their display when transitioning from ghost to real. https://code.launchpad.net/~gary/juju-gui/bug1157138/+merge/154099 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bug 1157138 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -32 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/models.js	View	2 chunks	+10 lines, -27 lines	0 comments	Download
M	test/test_fakebackend.js	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	test/test_model.js	View	1 chunk	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benji

LGTM https://codereview.appspot.com/7885045/diff/1/app/models/models.js File app/models/models.js (left): https://codereview.appspot.com/7885045/diff/1/app/models/models.js#oldcode128 app/models/models.js:128: }, Removing code is a wonderful thing. ;)

11 years, 1 month ago (2013-03-19 14:34:01 UTC) #2

matthew.scott

LGTM - good clean-up, I think. https://codereview.appspot.com/7885045/diff/1/app/models/models.js File app/models/models.js (left): https://codereview.appspot.com/7885045/diff/1/app/models/models.js#oldcode128 app/models/models.js:128: }, On 2013/03/19 ...

11 years, 1 month ago (2013-03-19 14:36:09 UTC) #3

gary.poster

11 years, 1 month ago (2013-03-19 14:55:43 UTC) #4

*** Submitted:

Fix bug 1157138

Make service displayName dynamic so that newly created services accurately
change their display when transitioning from ghost to real.

R=benji, matthew.scott
CC=
https://codereview.appspot.com/7885045

Expand All Messages | Collapse All Messages