Fail silently when annotations are misisng.

Fail silently when annotations are misisng.

If the 'landscape-computer(s)' annotations are missing in the DB, the GUI will now fail silently (along with a console.warn) rather than crashing horribly.  This is an intermediary fix, until UX is decided on for warning the user.

https://code.launchpad.net/~makyo/juju-gui/check-annotations-1156662/+merge/154106

(do not edit description out of merge proposal)

[matthew.scott, 2013-03-19 14:48:48]

Please take a look.

[jeff.pihach, 2013-03-19 15:24:16]

Thanks for this patch - Just curious if there is a typo or intentional

https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js
File app/views/landscape.js (right):

https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js#newcode130
app/views/landscape.js:130: var computer =
model.annotations['landscape-computer'];
is this supposed to be model.get('annotations') ?

[matthew.scott, 2013-03-19 15:56:34]

Thanks for the review.

https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js
File app/views/landscape.js (right):

https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js#newcode130
app/views/landscape.js:130: var computer =
model.annotations['landscape-computer'];
On 2013/03/19 15:24:16, jeff.pihach wrote:
> is this supposed to be model.get('annotations') ?

This is intentional, even if not ideal.  Many Unit attributes are accessed
directly.

[bcsaller, 2013-03-21 16:08:08]

LGTM with trivial

Thanks for the fix. Curious what conditions set the landscape-annotation on the
environment but not the units (and in turn the services?)

https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js
File app/views/landscape.js (right):

https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js#newcode130
app/views/landscape.js:130: var computer =
model.annotations['landscape-computer'];
On 2013/03/19 15:24:16, jeff.pihach wrote:
> is this supposed to be model.get('annotations') ?

So as to scale better units are not Models but rather POJOs.

https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js#newcode130
app/views/landscape.js:130: var computer =
model.annotations['landscape-computer'];
I think we are shadowing the previous var computers. I see that they are in
different lexical scopes but we should move the var up top and do the
assignments w/o it.

[gary.poster, 2013-03-21 16:19:55]

On 2013/03/19 15:56:34, matthew.scott wrote:
> Thanks for the review.
> 
> https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js
> File app/views/landscape.js (right):
> 
>
https://codereview.appspot.com/7884044/diff/1/app/views/landscape.js#newcode130
> app/views/landscape.js:130: var computer =
> model.annotations['landscape-computer'];
> On 2013/03/19 15:24:16, jeff.pihach wrote:
> > is this supposed to be model.get('annotations') ?
> 
> This is intentional, even if not ideal.  Many Unit attributes are accessed
> directly.

Yeah, all of them are, actually.  Machines are the same way.  This is because we
preemptively moved to a LazyModelList in order to scale to hundreds or more of
units and machines.

[jeff.pihach, 2013-03-21 16:27:19]

LGTM Thanks!

[matthew.scott, 2013-03-21 20:33:30]

*** Submitted:

Fail silently when annotations are misisng.

If the 'landscape-computer(s)' annotations are missing in the DB, the GUI will
now fail silently (along with a console.warn) rather than crashing horribly. 
This is an intermediary fix, until UX is decided on for warning the user.

R=jeff.pihach, bcsaller, gary.poster
CC=
https://codereview.appspot.com/7884044