Add cleanup to several api_test.go tests.

Add cleanup to several api_test.go tests.

Several state-changing op* tests in state/apiserver/api_test.go
do not return a reset() function, causing problems to other tests.
This branch adds those missing reset() functions. Thanks to
rogpeppe for guidance and fixes.

https://code.launchpad.net/~teknico/juju-core/fix-cleanup-in-api-tests/+merge/155540

(do not edit description out of merge proposal)

[teknico, 2013-03-26 16:00:06]

Please take a look.

[rog, 2013-03-26 16:22:32]

LGTM assuming the change below too.

https://codereview.appspot.com/7873046/diff/1/state/apiserver/api_test.go
File state/apiserver/api_test.go (right):

https://codereview.appspot.com/7873046/diff/1/state/apiserver/api_test.go#new...
state/apiserver/api_test.go:432: err := st.Client().AddServiceUnits("wordpress",
1)
sorry for not twigging this sooner, but we can use a similar approach here and
lose the latestUnit function.

func opClientAddServiceUnits(c *C, st *api.State, mst *state.State) (func(),
error) {
	err := st.Client().AddServiceUnits("nosuch", 1)
	if api.ErrCode(err) == api.CodeNotFound {
		err = nil
	}
	return func() {}, err
}

[dimitern, 2013-03-26 16:30:04]

LGTM

https://codereview.appspot.com/7873046/diff/1/state/apiserver/api_test.go
File state/apiserver/api_test.go (right):

https://codereview.appspot.com/7873046/diff/1/state/apiserver/api_test.go#new...
state/apiserver/api_test.go:413: units, err := svc.AllUnits()
it's a pity implementing this with sort(units)+get last index is actually not so
trivial.

[teknico, 2013-03-26 17:28:52]

*** Submitted:

Add cleanup to several api_test.go tests.

Several state-changing op* tests in state/apiserver/api_test.go
do not return a reset() function, causing problems to other tests.
This branch adds those missing reset() functions. Thanks to
rogpeppe for guidance and fixes.

R=rog, dimitern
CC=
https://codereview.appspot.com/7873046

[teknico, 2013-03-26 17:39:45]

Changes applied and landed, thanks.

https://codereview.appspot.com/7873046/diff/1/state/apiserver/api_test.go
File state/apiserver/api_test.go (right):

https://codereview.appspot.com/7873046/diff/1/state/apiserver/api_test.go#new...
state/apiserver/api_test.go:413: units, err := svc.AllUnits()
dimitern wrote:
> it's a pity implementing this with sort(units)+get last index
> is actually not so trivial.

Well, I'm removing this function anyway.

https://codereview.appspot.com/7873046/diff/1/state/apiserver/api_test.go#new...
state/apiserver/api_test.go:432: err := st.Client().AddServiceUnits("wordpress",
1)
rog wrote:
> LGTM assuming the change below too.

Added, thanks.