Issue 78730049: code review 78730049: cmd/gc: round floats with a large negative exponent tow...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 78730049: code review 78730049: cmd/gc: round floats with a large negative exponent tow... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by atom

Modified:
11 years ago

Reviewers:
rsc, iant

CC:
iant, rsc, golang-codereviews

Visibility:
Public.

Description

cmd/gc: round floats with a large negative exponent towards zero Fixes issue 6902

Patch Set 2 : diff -r 5cacef3086fb https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5cacef3086fb https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5cacef3086fb https://code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 62052ebe728b https://code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	src/cmd/gc/mparith1.c	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
	A	test/fixedbugs/issue6902.go	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

atom

Hello iant@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years ago (2014-03-23 10:29:44 UTC) #1

iant

https://codereview.appspot.com/78730049/diff/60001/src/cmd/gc/mparith1.c File src/cmd/gc/mparith1.c (right): https://codereview.appspot.com/78730049/diff/60001/src/cmd/gc/mparith1.c#newcode430 src/cmd/gc/mparith1.c:430: // 4 aproximates least_upper_bound(log2(10)). s/aproximates/approximates/

11 years ago (2014-03-23 22:02:08 UTC) #2

atom

11 years ago (2014-03-24 06:08:09 UTC) #3

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=cc814b1a9c42 *** cmd/gc: round floats with a large negative exponent towards zero ...

11 years ago (2014-03-24 17:10:36 UTC) #5

rsc

11 years ago (2014-03-24 18:41:27 UTC) #6

LGTM

This is a little weird, because now:

const (
    x = 1e-10000
    y = x == 0
)

y = true.

But that is allowed by the spec so let's run with it for now.

Expand All Messages | Collapse All Messages