Issue 7871045: code review 7871045: debug/dwarf: support for DWARF 3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7871045: code review 7871045: debug/dwarf: support for DWARF 3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rsc

Modified:
11 years, 1 month ago

Reviewers:
minux1, bradfitz, iant, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r ec901f2b8171 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ec901f2b8171 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5c43f676b8ec https://go.googlecode.com/hg/ #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -16 lines)			Patch
M	src/pkg/debug/dwarf/buf.go	View	1	3 chunks	+5 lines, -2 lines	2 comments	Download
M	src/pkg/debug/dwarf/entry.go	View	1	7 chunks	+13 lines, -7 lines	0 comments	Download
M	src/pkg/debug/dwarf/type.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/pkg/debug/dwarf/unit.go	View	1	2 chunks	+23 lines, -6 lines	0 comments	Download
M	src/pkg/debug/macho/file.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 1 month ago (2013-03-18 19:38:20 UTC) #1

bradfitz

https://codereview.appspot.com/7871045/diff/7001/src/pkg/debug/dwarf/buf.go File src/pkg/debug/dwarf/buf.go (right): https://codereview.appspot.com/7871045/diff/7001/src/pkg/debug/dwarf/buf.go#newcode43 src/pkg/debug/dwarf/buf.go:43: println(len(b.data), n) debug? https://codereview.appspot.com/7871045/diff/7001/src/pkg/debug/dwarf/buf.go#newcode142 src/pkg/debug/dwarf/buf.go:142: panic(1) debug?

11 years, 1 month ago (2013-03-18 19:51:23 UTC) #2

iant

I've got an alternate approach at https://codereview.appspot.com/7662045 that handles the 64-bit data format as well.

11 years, 1 month ago (2013-03-18 23:53:16 UTC) #4

*** Abandoned ***

Expand All Messages | Collapse All Messages