Add support for remove_relation in go.js.

Add support for remove_relation in go.js.



https://code.launchpad.net/~bac/juju-gui/destroy-relation/+merge/153898

(do not edit description out of merge proposal)

[bac, 2013-03-18 18:28:09]

Please take a look.

[gary.poster, 2013-03-18 19:04:00]

LGTM with trivial.  Thank you!

Gary

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js#newcode473
app/store/env/go.js:473: * @param {string} endpoint_b Name of the other service
in the relation.
Mention the callback arg?

[jeff.pihach, 2013-03-18 19:05:19]

Thanks for this - I'm curious as to why you're binding the method mentioned
below.

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js#newcode477
app/store/env/go.js:477: remove_relation: function(endpoint_a, endpoint_b,
callback) {
camelCase method and param names :)

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js#newcode481
app/store/env/go.js:481: intermediateCallback =
Y.bind(this.handleRemoveRelation, null,
Is there a reason why you are binding this method to null? You never reference
`this` in the handleRemoveRelation method so this is just a performance hit.

[jeff.pihach, 2013-03-18 19:17:39]

LGTM - as per our discussion in IRC - Thanks!

[bac, 2013-03-18 19:19:49]

Thanks for the reviews

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js#newcode473
app/store/env/go.js:473: * @param {string} endpoint_b Name of the other service
in the relation.
On 2013/03/18 19:04:00, gary.poster wrote:
> Mention the callback arg?

Done.

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js#newcode477
app/store/env/go.js:477: remove_relation: function(endpoint_a, endpoint_b,
callback) {
On 2013/03/18 19:05:19, jeff.pihach wrote:
> camelCase method and param names :)

remove_relation is legacy from the python implementation.  also the callsites
expect endpoint_a and endpoint_b, so i'd rather be locally consistent.  if we
ever do the camelCaseGeddon we can fix it up.

https://codereview.appspot.com/7871044/diff/1/app/store/env/go.js#newcode481
app/store/env/go.js:481: intermediateCallback =
Y.bind(this.handleRemoveRelation, null,
Yeah, as we discussed on IRC, to curry the endpoints.

[bac, 2013-03-19 12:27:54]

*** Submitted:

Add support for remove_relation in go.js.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/7871044