Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 7867046: code review 7867046: cmd/ld: fix OpenBSD (third try) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by iant
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, dave_cheney.net
Visibility:
Public.

Description

cmd/ld: fix OpenBSD (third try) On OpenBSD don't mark runtime.{g,m} as STT_TLS symbols.

Patch Set 1 #

Patch Set 2 : diff -r bb8b458a479c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/ld/symtab.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 1 month ago (2013-03-27 22:21:14 UTC) #1
dave_cheney.net
LGTM. I don't have an openbsd system to test on, but it's worth a try. ...
12 years, 1 month ago (2013-03-27 22:58:02 UTC) #2
iant
12 years, 1 month ago (2013-03-27 23:01:00 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=3d477c8de1c2 ***

cmd/ld: fix OpenBSD (third try)

On OpenBSD don't mark runtime.{g,m} as STT_TLS symbols.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7867046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b