LGTM. I don't have an openbsd system to test on, but it's worth a try. ...
12 years, 1 month ago
(2013-03-27 22:58:02 UTC)
#2
LGTM. I don't have an openbsd system to test on, but it's worth a try.
On Thu, Mar 28, 2013 at 9:21 AM, <iant@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/ld: fix OpenBSD (third try)
>
> On OpenBSD don't mark runtime.{g,m} as STT_TLS symbols.
>
> Please review this at https://codereview.appspot.com/7867046/
>
> Affected files:
> M src/cmd/ld/symtab.c
>
>
> Index: src/cmd/ld/symtab.c
> ===================================================================
> --- a/src/cmd/ld/symtab.c
> +++ b/src/cmd/ld/symtab.c
> @@ -153,7 +153,7 @@
> elfbind = STB_LOCAL;
> genasmsym(putelfsym);
>
> - if(linkmode == LinkExternal) {
> + if(linkmode == LinkExternal && HEADTYPE != Hopenbsd) {
> s = lookup("runtime.m", 0);
> if(s->sect == nil) {
> cursym = nil;
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Issue 7867046: code review 7867046: cmd/ld: fix OpenBSD (third try)
(Closed)
Created 12 years, 1 month ago by iant
Modified 12 years, 1 month ago
Reviewers:
Base URL:
Comments: 0