Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1589)

Issue 7861046: code review 7861046: text/template: fix bug in evaluating a chain starting w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by r
Modified:
11 years ago
Reviewers:
CC:
golang-dev, Hierro
Visibility:
Public.

Description

text/template: fix bug in evaluating a chain starting with a function.

Patch Set 1 #

Patch Set 2 : diff -r 7cd19e1a734a https://code.google.com/p/go #

Patch Set 3 : diff -r 7cd19e1a734a https://code.google.com/p/go #

Patch Set 4 : diff -r bb8b458a479c https://code.google.com/p/go #

Patch Set 5 : diff -r 6270bc68226e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M src/pkg/text/template/exec.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/text/template/exec_test.go View 1 2 3 2 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 13
r
Hello golang-dev@googlegroups.com (cc: alberto.garcia.hierro@gmail.com), I'd like you to review this change to https://code.google.com/p/go
11 years ago (2013-03-27 20:02:27 UTC) #1
Hierro
I really think this a design/usability mistake. The documentation on text/template and html/template is very ...
11 years ago (2013-03-27 22:03:38 UTC) #2
r
I am not changing the behavior of the template system, certainly not with Go 1.1 ...
11 years ago (2013-03-27 22:11:34 UTC) #3
r
Hello golang-dev@googlegroups.com, alberto.garcia.hierro@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2013-03-27 22:21:56 UTC) #4
r
Oh hell, you've talked me into it. PTAL. -rob
11 years ago (2013-03-27 22:21:56 UTC) #5
r
Hello golang-dev@googlegroups.com, alberto.garcia.hierro@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2013-03-27 22:22:57 UTC) #6
Hierro
I'm not proposing you make all those changes now, I understand some of them are ...
11 years ago (2013-03-27 22:31:56 UTC) #7
Hierro
Hi Rob, You're a fast typer! I was typing my previous reply while you already ...
11 years ago (2013-03-27 22:34:53 UTC) #8
r
It is your change but a much simpler test. -rob
11 years ago (2013-03-27 22:35:18 UTC) #9
Hierro
On 2013/03/27 22:35:18, r wrote: > It is your change but a much simpler test. ...
11 years ago (2013-03-27 22:37:28 UTC) #10
r
Hello golang-dev@googlegroups.com, alberto.garcia.hierro@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2013-03-27 22:42:44 UTC) #11
Hierro
LGTM, less code is always better.
11 years ago (2013-03-27 22:53:34 UTC) #12
r
11 years ago (2013-03-27 23:31:18 UTC) #13
*** Submitted as https://code.google.com/p/go/source/detail?r=8039bd09662b ***

text/template: fix bug in evaluating a chain starting with a function.

R=golang-dev, alberto.garcia.hierro
CC=golang-dev
https://codereview.appspot.com/7861046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b