Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 7857044: code review 7857044: net: fix build with CGO_ENABLED=0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dvyukov
Modified:
12 years ago
Reviewers:
CC:
golang-dev, rsc, mikio
Visibility:
Public.

Description

net: fix build with CGO_ENABLED=0

Patch Set 1 #

Patch Set 2 : diff -r 5957d9d08900 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 5957d9d08900 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 094f23d58914 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 094f23d58914 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A src/pkg/net/empty.c View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years ago (2013-03-15 17:30:36 UTC) #1
rsc
LGTM
12 years ago (2013-03-15 17:51:30 UTC) #2
mikio
LGTM cgo_disabled.c?
12 years ago (2013-03-15 17:55:10 UTC) #3
rsc
it's not really fundamental to cgo. cgo is just masking the problem
12 years ago (2013-03-15 17:59:07 UTC) #4
dvyukov
12 years ago (2013-03-15 18:23:43 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=4f4a78297e7a ***

net: fix build with CGO_ENABLED=0

R=golang-dev, rsc, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7857044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b