Issue 7856049: Method as keyword param in httplib2.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7856049: Method as keyword param in httplib2.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by jcgregorio_google

Modified:
11 years, 1 month ago

Reviewers:
dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Pass method to httplib2 as a keywork param. Fixes issue #190.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	apiclient/http.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dhermes

Does this not apply in: https://code.google.com/p/google-api-python-client/source/browse/oauth2client/client.py?r=19f026b9a382ab73f56f15101ee1f0b945a4536f#496 I assume not since util isn't used in httplib2, ...

11 years, 1 month ago (2013-03-26 15:43:47 UTC) #2

jcgregorio_google

11 years, 1 month ago (2013-03-26 17:19:06 UTC) #3

Actually that's a good catch, they should be supplied there also.

On Tue, Mar 26, 2013 at 11:43 AM,  <dhermes@google.com> wrote:
> Does this not apply in:
>
https://code.google.com/p/google-api-python-client/source/browse/oauth2client...
>
> I assume not since util isn't used in httplib2, but I could be wrong.
>
> https://codereview.appspot.com/7856049/

Expand All Messages | Collapse All Messages