Issue 7850045: code review 7850045: cmd/gc: steal escape analysis info when inlining

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7850045: code review 7850045: cmd/gc: steal escape analysis info when inlining (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by DMorsing

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc, remyoudompheng

Visibility:
Public.

Description

cmd/gc: steal escape analysis info when inlining Usually, there is no esc info when inlining, but there will be when generating inlined wrapper functions. If we don't use this information, we get invalid addresses on the stack. Fixes issue 5056.

Patch Set 1 #

Patch Set 2 : diff -r b5b5c246be0c https://code.google.com/p/go/ #

Patch Set 3 : diff -r b5b5c246be0c https://code.google.com/p/go/ #

Patch Set 4 : diff -r b5b5c246be0c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 7a70129d0a6e https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	src/cmd/gc/inl.c	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
	A	test/fixedbugs/issue5056.go	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

DMorsing

Hello golang-dev@googlegroups.com (cc: remyoudompheng@gmail.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-03-16 11:44:08 UTC) #1

DMorsing

12 years, 2 months ago (2013-03-18 21:22:43 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=0970a243a5d3 ***

cmd/gc: steal escape analysis info when inlining

Usually, there is no esc info when inlining, but there will be when generating
inlined wrapper functions.

If we don't use this information, we get invalid addresses on the stack.

Fixes issue 5056.

R=golang-dev, rsc
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/7850045

Expand All Messages | Collapse All Messages