Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(210)

Issue 7849048: Fix issue with npm package.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by arv
Modified:
13 years, 2 months ago
Reviewers:
peterhal, usrbincc
CC:
traceur-compiler-reviews_googlegroups.com
Base URL:
https://code.google.com/p/traceur-compiler/@master
Visibility:
Public.

Description

Fix issue with npm package.js The main field should point to a file that can be directly required. With this change the following should work npm install traceur -g and in your node file var traceur = require('traceur'); BUG=None Committed: https://code.google.com/p/traceur-compiler/source/detail?r=74e5bd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M package.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
arv
I'm not really sure how to test this without pushing to npmjs.org
13 years, 2 months ago (2013-03-22 16:55:43 UTC) #1
peterhal
LGTM
13 years, 2 months ago (2013-03-22 17:46:05 UTC) #2
peterhal
On 2013/03/22 17:46:05, peterhal wrote: > LGTM We should get in the habit of submitting ...
13 years, 2 months ago (2013-03-22 17:46:55 UTC) #3
arv
13 years, 2 months ago (2013-03-22 18:55:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r74e5bd0 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b