Issue 7838048: code review 7838048: cmd/gc: fix line number for 'missing return' in closure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7838048: code review 7838048: cmd/gc: fix line number for 'missing return' in closure (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: fix line number for 'missing return' in closure

Patch Set 1 #

Patch Set 2 : diff -r b0d920685dda https://code.google.com/p/go/ #

Patch Set 3 : diff -r c61a75775ab6 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1439 lines, -1 line)			Patch
M	src/cmd/gc/closure.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/fmt.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/return.go	View	1	1 chunk	+1436 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-03-22 21:50:28 UTC) #1

rsc

12 years ago (2013-03-22 21:50:35 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=f3298a9f1b89 ***

cmd/gc: fix line number for 'missing return' in closure

R=ken2
CC=golang-dev
https://codereview.appspot.com/7838048

Expand All Messages | Collapse All Messages