This patch needs a review from someone more knowledgeable in docs/snippets than me. https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly File ...
11 years, 1 month ago
(2013-03-17 16:24:16 UTC)
#3
On 2013/03/17 16:24:16, janek wrote: > This patch needs a review from someone more knowledgeable ...
11 years, 1 month ago
(2013-03-17 17:26:20 UTC)
#4
On 2013/03/17 16:24:16, janek wrote:
> This patch needs a review from someone more knowledgeable in docs/snippets
than
> me.
+1
All I did was:
I copied the files from /Documentation/snippets into
/Documentation/snippets/new.
Removed the '-signs, deleted the comments above the old version-statement,
changed the version and ran scripts/auxiliar/makelsr.py
Concerning the version: The whole point of the issue is that '-signs in vectors
are superfluous.
Also, they were superfluous with former versions, perhaps always.
So I choosed 2.17.15 somewhat arbitrary, though, I see no problem here.
I didn't touch anything else. All other changes were made by
scripts/auxiliar/makelsr.py
https://codereview.appspot.com/7834043/diff/13001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly File Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly (right): https://codereview.appspot.com/7834043/diff/13001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly#newcode26 Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly:26: It is conceivable that removing one (or two?) line ...
11 years, 1 month ago
(2013-03-26 20:28:09 UTC)
#8
On 2013/04/02 21:35:23, janek wrote: > Is this patch still valid? I don't see any ...
11 years, 1 month ago
(2013-04-02 23:41:08 UTC)
#11
On 2013/04/02 21:35:23, janek wrote:
> Is this patch still valid? I don't see any ' signs being removed,
Meanwhile I removed the '-signs from the relevant snippets in LSR as well. I
wasn't aware that a new release would contain them.
So it is indeed invalid.
git grep "#'#" only returns some occurrences in doc-translations.
What to do? Close the issue?
> only some
> semi-random "side-effects" here and there.
What do you mean here?
Hi, On Wed, Apr 3, 2013 at 1:41 AM, <thomasmorley65@googlemail.com> wrote: > On 2013/04/02 21:35:23, ...
11 years, 1 month ago
(2013-04-03 08:25:33 UTC)
#12
Hi,
On Wed, Apr 3, 2013 at 1:41 AM, <thomasmorley65@googlemail.com> wrote:
> On 2013/04/02 21:35:23, janek wrote:
>>
>> Is this patch still valid? I don't see any ' signs being removed,
>
> Meanwhile I removed the '-signs from the relevant snippets in LSR as
> well. I wasn't aware that a new release would contain them.
>
> So it is indeed invalid.
> git grep "#'#" only returns some occurrences in doc-translations.
>
> What to do? Close the issue?
I think so - both this and tracker issue, possibily with a comment.
>> only some
>> semi-random "side-effects" here and there.
>
> What do you mean here?
All remaining changes, which look strange - removed lines, changed
comments, etc.
best,
Janek
Janek Warchoł <janek.lilypond@gmail.com> writes: > Hi, > > On Wed, Apr 3, 2013 at 1:41 ...
11 years, 1 month ago
(2013-04-03 08:31:26 UTC)
#13
Janek Warchoł <janek.lilypond@gmail.com> writes:
> Hi,
>
> On Wed, Apr 3, 2013 at 1:41 AM, <thomasmorley65@googlemail.com> wrote:
>> On 2013/04/02 21:35:23, janek wrote:
>>>
>>> Is this patch still valid? I don't see any ' signs being removed,
>>
>> Meanwhile I removed the '-signs from the relevant snippets in LSR as
>> well. I wasn't aware that a new release would contain them.
makelsr takes everything from the LSR that has not been superseded by a
snippet in the "new" directory.
>> So it is indeed invalid.
More likely "Fixed", but "Patch-abandoned" (or tag removed altogether)
since the fix did not travel via the patch and the standard repository
mechanism.
Perhaps double-check that the % end verbatim occurs only where expected
in master, and then close as fixed, possibly with the version number
where the fix traveled in via makelsr.
--
David Kastrup
On 2013/04/03 08:31:26, dak wrote: > Perhaps double-check that the % end verbatim occurs only ...
11 years, 1 month ago
(2013-04-04 15:34:16 UTC)
#14
On 2013/04/03 08:31:26, dak wrote:
> Perhaps double-check that the % end verbatim occurs only where expected
> in master,
Done.
> and then close as fixed, possibly with the version number
> where the fix traveled in via makelsr.
Done.
Issue 7834043: Removes '-signs in vectors - follow-up
(Closed)
Created 11 years, 1 month ago by thomasmorley65
Modified 11 years, 1 month ago
Reviewers: janek, dak
Base URL:
Comments: 6
