Issue 7832045: Add parse tree writer round trip testing to feature tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7832045: Add parse tree writer round trip testing to feature tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by peterhal

Modified:
13 years, 2 months ago

Reviewers:
arv

CC:
traceur-compiler-reviews_googlegroups.com

Base URL:
https://code.google.com/p/traceur-compiler/@master

Visibility:
Public.

More Reviews

Description

Add parse tree writer round trip testing to feature tests. This will expose bugs in the ParseTreeWriter for all language features encountered in feature tests. Fixes bug for ParseTreeWriter and ArrayComprehension. Refactors testfeatures.js. BUG= Committed: https://code.google.com/p/traceur-compiler/source/detail?r=7e0c8d4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review. #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -55 lines)			Patch
M	bin/traceur.js	View		6 chunks	+62 lines, -5 lines	0 comments	Download
M	src/outputgeneration/ParseTreeWriter.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	test/testfeatures.js	View	1	3 chunks	+106 lines, -49 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

arv

LGTM I can merge this to GitHub if you want to commit this to Google ...

13 years, 2 months ago (2013-03-27 23:34:16 UTC) #2

peterhal

13 years, 2 months ago (2013-03-27 23:58:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r7e0c8d4 (presubmit successful).

Expand All Messages | Collapse All Messages