code review 7813045: build: fix for mingw64 compiled on 32-bit system

build: fix for 32-bit windows builds on 64-bit windows system

Thanks to jon.forums@ for the fix.

Fixes issue 5051.

[rsc, 2013-03-15 15:40:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2013-03-15 15:58:15]

LGTM. This fixes the compilation error when using mingw64 with
GOHOSTARCH=386 GOARCH=386.

[rsc, 2013-03-15 16:36:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=fbba146ff012 ***

build: fix for 32-bit windows builds on 64-bit windows system

Thanks to jon.forums@ for the fix.

Fixes issue 5051.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7813045

[Joe Poirier, 2013-03-15 17:02:45]

tl;dr, _TIMESPEC_DEFINED may be a better fit (#if !defined(_WIN64) &&
!defined(_TIMESPEC_DEFINED)). See "http://tinyurl.com/clafx94" line 88. 


Why __MINGW64_VERSION_MAJOR instead of __MINGW64__? 

__MINGW32__ and __MINGW64__ are global whereas the *_MINOR and *_MAJOR flags are
defined via header files, e.g when <stdlib.h>, <stdio.h>, <windows.h>,
<windef.h>, and others are included.

Type                 Macro                                      Description     
 MinGW32	 MinGW-w64 32 Bit	MinGW-w64 64 Bit
Identification    __MINGW32__                                                  
defined           defined                   defined
Version            __MINGW32_MAJOR_VERSION   Version              defined       
  defined                    defined
Version            __MINGW32_MINOR_VERSION   Revision             defined       
  defined                    defined
Identification   __MINGW64__                                                    
   -                    -                          defined
Version            __MINGW64_VERSION_MAJOR   Version                 -          
      defined                    defined
Version            __MINGW64_VERSION_MINOR   Revision                -          
      defined                    defined

[rsc, 2013-03-15 17:04:58]

I just took the suggestion in the issue. I'm fine with anything that works.

[Joe Poirier, 2013-03-15 17:06:24]

Sorry about the table. Here's the link with the info (MinGW section):
http://sourceforge.net/p/predef/wiki/Compilers/