Issue 78100044: code review 78100044: cmd/6g, cmd/8g: skip CONVNOP nodes in bgen.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 78100044: code review 78100044: cmd/6g, cmd/8g: skip CONVNOP nodes in bgen. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by remyoudompheng

Modified:
11 years, 2 months ago

Reviewers:
khr

CC:
rsc, dave_cheney.net, iant, khr, golang-codereviews

Visibility:
Public.

Description

cmd/6g, cmd/8g: skip CONVNOP nodes in bgen. Revision 3ae4607a43ff introduced CONVNOP layers to fix type checking issues arising from comparisons. The added complexity made 8g run out of registers when compiling an equality function in go.net/ipv6. A similar issue occurred in test/sizeof.go on amd64p32 with 6g. Fixes issue 7405.

Patch Set 1 #

Patch Set 2 : diff -r 32c32aef2a41 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 32c32aef2a41 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ab0ea248ed7c https://go.googlecode.com/hg/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -0 lines)			Patch
M	src/cmd/6g/cgen.c	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue7405.go	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, dave@cheney.net, iant@golang.org, khr@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...

11 years, 2 months ago (2014-03-20 06:57:22 UTC) #1

remyoudompheng

This patch also has the effect of making test/run.go pass completely on nacl/amd64p32 (sizeof.go was ...

11 years, 2 months ago (2014-03-20 07:01:18 UTC) #2

remyoudompheng

11 years, 2 months ago (2014-03-20 21:22:49 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=da4fb43ab08e ***

cmd/6g, cmd/8g: skip CONVNOP nodes in bgen.

Revision 3ae4607a43ff introduced CONVNOP layers
to fix type checking issues arising from comparisons.
The added complexity made 8g run out of registers
when compiling an equality function in go.net/ipv6.

A similar issue occurred in test/sizeof.go on
amd64p32 with 6g.

Fixes issue 7405.

LGTM=khr
R=rsc, dave, iant, khr
CC=golang-codereviews
https://codereview.appspot.com/78100044

Expand All Messages | Collapse All Messages