Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(380)

Issue 78070043: cmd/juju: revert proxy changes in CLI

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by axw
Modified:
7 years, 8 months ago
Reviewers:
mp+211853, thumper
Visibility:
Public.

Description

cmd/juju: revert proxy changes in CLI I'm reverting the changes to the CLI only, as juju ssh support for the local provider regressed (broken if machine 0 doesn't have an SSH server available.) We'll keep the API and utils/ssh changes needed to re-enable this after 1.18 is released. https://code.launchpad.net/~axwalk/juju-core/ssh-disable-proxy/+merge/211853 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -149 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/scp.go View 1 chunk +1 line, -9 lines 0 comments Download
M cmd/juju/scp_test.go View 2 chunks +58 lines, -56 lines 0 comments Download
M cmd/juju/ssh.go View 9 chunks +11 lines, -74 lines 0 comments Download
M cmd/juju/ssh_test.go View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
7 years, 8 months ago (2014-03-20 02:35:16 UTC) #1
thumper
7 years, 8 months ago (2014-03-20 02:40:05 UTC) #2
On 2014/03/20 02:35:16, axw wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b