Issue 7802046: Fix issue 223, CloneTreeTransformation fails on trees with empty lists Add transformList() and retu…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7802046: Fix issue 223, CloneTreeTransformation fails on trees with empty lists Add transformList() and retu… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by johnjbarton

Modified:
13 years, 1 month ago

Reviewers:
arv

CC:
traceur-compiler-reviews_googlegroups.com

Base URL:
https://code.google.com/p/traceur-compiler/@master

Visibility:
Public.

More Reviews

Description

Fix issue 223, CloneTreeTransformation fails on trees with empty lists Add transformList() and return new array of the list is empty, since this another example of a leaf of the AST BUG=https://code.google.com/p/traceur-compiler/issues/detail?id=223

Patch Set 1 #

Total comments: 1

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	bin/traceur.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	src/codegeneration/CloneTreeTransformer.js	View		1 chunk	+12 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

arv

13 years, 2 months ago (2013-03-24 13:17:35 UTC) #1

https://codereview.appspot.com/7802046/diff/1/src/codegeneration/CloneTreeTra...
File src/codegeneration/CloneTreeTransformer.js (right):

https://codereview.appspot.com/7802046/diff/1/src/codegeneration/CloneTreeTra...
src/codegeneration/CloneTreeTransformer.js:130: if (list == null || list.length
== 0) {
If list is null, should we not return null then?

Expand All Messages | Collapse All Messages