Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(261)

Issue 78010043: use unique_ptr instead of auto_ptr in c++11 mode

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by mostynb
Modified:
11 years, 3 months ago
Reviewers:
thakis, jochen1, Lincoln
CC:
open-vcdiff_googlegroups.com
Base URL:
http://open-vcdiff.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Use unique_ptr instead of auto_ptr in c++11 mode. Tested with gcc 4.8.1 on linux with -std=gnu+=11 and -std=c++11.

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M src/blockhash_test.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
A src/unique_ptr.h View 1 2 1 chunk +32 lines, -0 lines 2 comments Download
M src/vcdecoder.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/vcdiff_main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/vcencoder.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
mostynb
Please take a look...
11 years, 5 months ago (2014-03-19 23:11:05 UTC) #1
Lincoln
Thanks very much for the patch, and sorry for the delay in reviewing it! https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h ...
11 years, 5 months ago (2014-04-08 18:55:17 UTC) #2
Lincoln
https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h File src/unique_ptr.h (right): https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h#newcode1 src/unique_ptr.h:1: #ifndef UNIQUE_PTR_H This needs to start with a comment ...
11 years, 5 months ago (2014-04-08 18:58:17 UTC) #3
mostynb
https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h File src/unique_ptr.h (right): https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h#newcode1 src/unique_ptr.h:1: #ifndef UNIQUE_PTR_H On 2014/04/08 18:58:18, Lincoln wrote: > This ...
11 years, 5 months ago (2014-04-08 20:58:14 UTC) #4
thakis
Lincoln: Ping.
11 years, 4 months ago (2014-04-28 03:01:29 UTC) #5
Lincoln
I'm very sorry for the long delay in responding! I wanted to double-check about what ...
11 years, 3 months ago (2014-05-14 00:00:30 UTC) #6
mostynb
11 years, 3 months ago (2014-05-14 08:49:57 UTC) #7
https://codereview.appspot.com/78010043/diff/40001/src/unique_ptr.h
File src/unique_ptr.h (right):

https://codereview.appspot.com/78010043/diff/40001/src/unique_ptr.h#newcode1
src/unique_ptr.h:1: // Copyright 2014 Opera Software ASA. All Rights Reserved.
On 2014/05/14 00:00:30, Lincoln wrote:
> Mostyn, would you and Opera be willing to use the following copyright
statement
> instead?
> // Copyright 2014 The open-vcdiff Authors. All Rights Reserved.
> 
> I have just changed all our source files to use this form in place of the
> previous "Copyright ... Google Inc."  That change will be a part of the next
> open-vcdiff release.  This is the first time we are accepting an entire file
> (however small) from a source other than Google.  The Chromium project uses a
> similar format for "The Chromium Authors":
> http://www.chromium.org/developers/coding-style

Done.

I'm having trouble remembering how to update CL's with gcl/svn, so I submitted a
new CL with this change here (I also added my name to the THANKS file): 
https://codereview.appspot.com/92310046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b