Issue 92310046: Use unique_ptr instead of auto_ptr in c++11 mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92310046: Use unique_ptr instead of auto_ptr in c++11 mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by mostynb

Modified:
11 years, 4 months ago

Reviewers:
thakis, jochen1, Lincoln

CC:
open-vcdiff_googlegroups.com

Base URL:
http://open-vcdiff.googlecode.com/svn/trunk/

Visibility:
Public.

Use unique_ptr instead of auto_ptr in c++11 mode. Tested with gcc 4.8.1 on linux with -std=gnu+=11 and -std=c++11.

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -14 lines)			Patch
M	THANKS	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/blockhash_test.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
A	src/unique_ptr.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	src/vcdecoder.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/vcdiff_main.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/vcencoder.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3

mostynb

@Lincoln: this is a version of https://codereview.appspot.com/78010043/ with the change you requested.

11 years, 4 months ago (2014-05-14 08:49:08 UTC) #1

Lincoln

LGTM Thank you very much for contributing to open-vcdiff! I will include the patch in ...

11 years, 4 months ago (2014-05-14 16:49:45 UTC) #2

Included in open-vcdiff version 0.8.4.