Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 92310046: Use unique_ptr instead of auto_ptr in c++11 mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by mostynb
Modified:
11 years, 3 months ago
Reviewers:
thakis, jochen1, Lincoln
CC:
open-vcdiff_googlegroups.com
Base URL:
http://open-vcdiff.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Use unique_ptr instead of auto_ptr in c++11 mode. Tested with gcc 4.8.1 on linux with -std=gnu+=11 and -std=c++11.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M THANKS View 1 chunk +1 line, -1 line 1 comment Download
M src/blockhash_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A src/unique_ptr.h View 1 chunk +32 lines, -0 lines 0 comments Download
M src/vcdecoder.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/vcdiff_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/vcencoder.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
mostynb
@Lincoln: this is a version of https://codereview.appspot.com/78010043/ with the change you requested.
11 years, 3 months ago (2014-05-14 08:49:08 UTC) #1
Lincoln
LGTM Thank you very much for contributing to open-vcdiff! I will include the patch in ...
11 years, 3 months ago (2014-05-14 16:49:45 UTC) #2
Lincoln
11 years, 3 months ago (2014-05-14 23:23:12 UTC) #3
Included in open-vcdiff version 0.8.4.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b