Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 7799046: code review 7799046: os/exec: fix fd leak with Std*Pipe + LookPath (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by bradfitz
Modified:
6 years, 6 months ago
Reviewers:
CC:
golang-dev, rog
Visibility:
Public.

Description

os/exec: fix fd leak with Std*Pipe + LookPath If LookPath in Command fails, sets a sticky error, and then StdinPipe, StdoutPipe, or StderrPipe were called, those pipe fds were never cleaned up. Fixes issue 5071

Patch Set 1 #

Patch Set 2 : diff -r 43eb97ed849a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 43eb97ed849a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 43eb97ed849a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/pkg/os/exec/exec.go View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/os/exec/exec_test.go View 1 3 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 6 months ago (2013-03-18 14:56:04 UTC) #1
rog
On 2013/03/18 14:56:04, bradfitz wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
6 years, 6 months ago (2013-03-18 16:04:18 UTC) #2
bradfitz
I anticipated this complaint. See the earlier patchset in that CL for another approach. I ...
6 years, 6 months ago (2013-03-18 16:09:14 UTC) #3
rog
On 18 March 2013 16:09, Brad Fitzpatrick <bradfitz@golang.org> wrote: > I anticipated this complaint. See ...
6 years, 6 months ago (2013-03-18 16:47:59 UTC) #4
bradfitz
6 years, 6 months ago (2013-03-18 16:52:47 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=bcb5f45aa10e ***

os/exec: fix fd leak with Std*Pipe + LookPath

If LookPath in Command fails, sets a sticky error, and then
StdinPipe, StdoutPipe, or StderrPipe were called, those pipe
fds were never cleaned up.

Fixes issue 5071

R=golang-dev, rogpeppe
CC=golang-dev
https://codereview.appspot.com/7799046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b